Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1542] add missed optional chaining #865

Merged
merged 1 commit into from
Sep 22, 2023
Merged

[R20-1542] add missed optional chaining #865

merged 1 commit into from
Sep 22, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 20, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1542

What I did

  • add missed optional chaining

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Sep 20, 2023
@netlify
Copy link

netlify bot commented Sep 20, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 23e6807
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/650b72dadd1c7200084c4ec6

@lambry lambry added this pull request to the merge queue Sep 22, 2023
Merged via the queue into develop with commit 6c4ec86 Sep 22, 2023
@lambry lambry deleted the bugfix/publication-author branch September 22, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@lambry lambry

Labels
Needs Code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle