Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1522] increase menu depth for breadcrumbs #862

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 19, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1522

What I did

  • increase menu query depth so breadcrumbs work on deeply nested pages
  • added ? to menu URL generation as I noticed when testing this against legalaid (develop) some deeply nested items don't actually have a URL
Screenshot 2023-09-20 at 9 54 19 am

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 0f84540
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/650d2f7caf58d6000822ac14

@cypress
Copy link

cypress bot commented Sep 20, 2023

Passing run #725 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-api): add optional chaining
Project: ripple-framework Commit: 0f84540a7d
Status: Passed Duration: 06:22 💡
Started: Sep 22, 2023 6:12 AM Ended: Sep 22, 2023 6:19 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly dylankelly added this pull request to the merge queue Sep 24, 2023
Merged via the queue into develop with commit 982060d Sep 24, 2023
@waitingallday waitingallday deleted the bugfix/menu-depth branch October 25, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants