Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@dpc-sdp/ripple-tide-search): added sort dropdown to custom collection #858

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented Sep 19, 2023

Issue:

What I did

  • added sort dropdown to custom collection
  • added loading state for custom collection
  • tidied up error display for both search listing and custom collection
  • fixed custom collection scroll to top bug

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

…ection

also added loading state and tidied up error display
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit bc8dc3b
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65093b610bc69f0008901212

@cypress
Copy link

cypress bot commented Sep 19, 2023

Passing run #709 ↗︎

0 99 0 0 Flakiness 0

Details:

test(@dpc-sdp/ripple-tide-search): fixed up custom collection test table results
Project: ripple-framework Commit: bc8dc3b5e7
Status: Passed Duration: 07:25 💡
Started: Sep 19, 2023 6:15 AM Ended: Sep 19, 2023 6:23 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jeffdowdle jeffdowdle self-assigned this Sep 19, 2023
@jeffdowdle jeffdowdle marked this pull request as ready for review September 19, 2023 00:55
@dylankelly dylankelly added this pull request to the merge queue Sep 19, 2023
Merged via the queue into develop with commit cb7d630 Sep 19, 2023
9 checks passed
@waitingallday waitingallday deleted the feature/R20-1175-sort-options branch October 25, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants