Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@dpc-sdp/ripple-tide-search): fixed global filters not being applied to aggregations query #854

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

  • Added global filters to the aggregrations request so that you only get aggregations from the results you are searching

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 8f7a280
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6503b0f58dffeb0008a78a22

@cypress
Copy link

cypress bot commented Sep 15, 2023

Passing run #677 ↗︎

0 96 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): fixed global filters not being applied to aggr...
Project: ripple-framework Commit: 8f7a280122
Status: Passed Duration: 04:32 💡
Started: Sep 15, 2023 1:20 AM Ended: Sep 15, 2023 1:24 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jeffdowdle jeffdowdle added this pull request to the merge queue Sep 18, 2023
Merged via the queue into develop with commit 7f6ba9a Sep 18, 2023
9 checks passed
@waitingallday waitingallday deleted the bugfix/aggs-filter branch October 25, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants