Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🚀 change publish process to be on release #845

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

dylankelly
Copy link
Contributor

@dylankelly dylankelly commented Sep 8, 2023

Issue:

What I did

  • Make NPM publish step come from GH Release instead of merge to main

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 9e86c52
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64fa70dbefea39000888d608

@dylankelly dylankelly merged commit 30932ae into develop Sep 8, 2023
14 checks passed
@waitingallday waitingallday deleted the feature/publish-on-release branch October 25, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants