Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1511] add dataLayer event for error pages #831

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 4, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1511

What I did

  • Use new tide hook for dataLayer events so DL event includes 404 pages

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit e447970
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64f66269ed07d00008f14f1d

@lambry lambry self-assigned this Sep 4, 2023
@cypress
Copy link

cypress bot commented Sep 4, 2023

Passing run #591 ↗︎

0 93 0 0 Flakiness 0

Details:

fix(@dpc-sdp/nuxt-ripple-analytics): use new tide hook for dataLayer events
Project: ripple-framework Commit: e447970e04
Status: Passed Duration: 04:27 💡
Started: Sep 4, 2023 11:07 PM Ended: Sep 4, 2023 11:11 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly dylankelly self-requested a review September 4, 2023 10:22
@lambry lambry marked this pull request as ready for review September 4, 2023 23:05
@@ -31,10 +31,8 @@ export default defineNuxtPlugin((nuxtApp) => {

/* @ts-ignore process is extended by webpack */
if (process.client) {
nuxtApp.hook('page:finish', () => {
nuxtApp.hook('tide:page', ({ page, site }) => {
const route = useRoute()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dylankelly dylankelly added this pull request to the merge queue Sep 5, 2023
Merged via the queue into develop with commit 42d0820 Sep 5, 2023
9 checks passed
@lambry lambry deleted the feature/datalayer-error-event branch September 22, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants