Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1493] Add accessible label to links opening in a new window #819

Merged
merged 4 commits into from
Sep 3, 2023

Conversation

waitingallday
Copy link
Member

@waitingallday waitingallday commented Aug 29, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1493

What I did

  • Added accessible label in RplTextLink
  • Added accessible label in RplDocument
  • Added accessible label in cheerio for RplContent
  • Updated a unit test to demonstrate
  • Added a type abstraction to get rid of hastitle and hassidebar attrs in dynamic page component rendered markup

How to test

  • Unit test
  • e2e: create a link with target="_blank" in content managed block on BE, check output on FE

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Aug 29, 2023
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 626f2ee
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64ed874c3b05b700087411bb

@cypress
Copy link

cypress bot commented Aug 29, 2023

Passing run #545 ↗︎

0 92 0 0 Flakiness 0

Details:

revert(nuxt-app): ⏪ remove debug
Project: ripple-framework Commit: 626f2eeca8
Status: Passed Duration: 07:19 💡
Started: Aug 29, 2023 5:51 AM Ended: Aug 29, 2023 5:59 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly dylankelly added this pull request to the merge queue Sep 3, 2023
Merged via the queue into develop with commit eb673aa Sep 3, 2023
9 checks passed
@waitingallday waitingallday deleted the feat/r20-1493-add-text-link branch October 25, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants