Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1463] add custom loading indicator #792

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 21, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1463

What I did

Screenshot 2023-08-22 at 9 33 02 am

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@codesandbox
Copy link

codesandbox bot commented Aug 21, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 258ea4b
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64e3f70aa4f8800008a2efbe

@dylankelly dylankelly added this pull request to the merge queue Aug 22, 2023
Merged via the queue into develop with commit 5f49e5b Aug 22, 2023
@lambry lambry deleted the bugfix/loading-inidcator branch September 22, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants