Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cypress action for layers so that it is generic for all layers #785

Merged
merged 15 commits into from
Aug 21, 2023

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Aug 17, 2023
@codesandbox
Copy link

codesandbox bot commented Aug 17, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit b482350
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64dea32eb0ff53000844a954

@cypress
Copy link

cypress bot commented Aug 17, 2023

Passing run #400 ↗︎

0 86 0 0 Flakiness 0

Details:

chore(@dpc-sdp/nuxt-ripple-cli): added missing files to layer ci command
Project: ripple-framework Commit: b482350288
Status: Passed Duration: 06:33 💡
Started: Aug 17, 2023 10:50 PM Ended: Aug 17, 2023 10:57 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jeffdowdle jeffdowdle marked this pull request as ready for review August 17, 2023 05:56
@jeffdowdle jeffdowdle requested review from dylankelly, waitingallday and lambry and removed request for dylankelly August 17, 2023 05:56
@jeffdowdle jeffdowdle changed the title test: refactor page and site mocking step definitions Update cypress action for layers so that it is generic for all layers Aug 17, 2023
@waitingallday waitingallday added this pull request to the merge queue Aug 20, 2023
Merged via the queue into develop with commit 801e29a Aug 21, 2023
@waitingallday waitingallday deleted the chore/cypress-env-ci branch October 25, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants