Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1321] Add custom collection #777

Merged
merged 21 commits into from
Sep 5, 2023
Merged

Conversation

dylankelly
Copy link
Contributor

@dylankelly dylankelly commented Aug 15, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1321

What I did

  • Added TideCustomCollection component - this will be used for custom search experiences in Landing page content types. It will be used first for the Cameras save lives location table.
  • Adds API endpoint for proxying elasticsearch requests seperate to app search (would be good to also consolidate content collection in a follow up PR)
  • Refactors search page components to be consistent

How to test

  • Added integration tests
  • To test manually
    • Set NUXT_PUBLIC_TIDE_ELASTICSEARCH_HOST=https://a83890f7a31dea14e1ae83c6f0afacca.sdp2-b.elastic.sdp.vic.gov.au
    • Create landing page with Custom collection component - See examples/nuxt-app/test/fixtures/landingpage/custom-collection.json props object for JSON config

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@codesandbox
Copy link

codesandbox bot commented Aug 15, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 2304ad5
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64f5b13a5f581b0008df931c

@cypress
Copy link

cypress bot commented Aug 15, 2023

Passing run #587 ↗︎

0 96 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): 🐛 fix autocomplete end point
Project: ripple-framework Commit: 2304ad5ddd
Status: Passed Duration: 05:33 💡
Started: Sep 4, 2023 10:32 AM Ended: Sep 4, 2023 10:37 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly dylankelly self-assigned this Aug 15, 2023
},
"searchListingConfig": {
"searchProvider": "elasticsearch",
"index": "sdp_data_pipelines_scl",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the node index as default

@dylankelly dylankelly marked this pull request as ready for review August 22, 2023 07:09
@lambry

This comment was marked as outdated.

@dylankelly
Copy link
Contributor Author

Hey @dylankelly,

  • Should the autocomplete be working? (and debounced)
  • Might needs a little spacing here Screenshot 2023-08-28 at 10 42 32 am

Cheers

Autocomplete won't be a thing. I've advised Jess. Have fixed up spacing

Copy link
Contributor

@jeffdowdle jeffdowdle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get search listing running locally, just setting this to 'request changes' so that this doesn't get merged with possible issues

@dylankelly
Copy link
Contributor Author

I couldn't get search listing running locally, just setting this to 'request changes' so that this doesn't get merged with possible issues

@jeffdowdle this had an issue with the proxy setup - fixed here

Have put test .env in slack

@dylankelly dylankelly dismissed jeffdowdle’s stale review September 5, 2023 23:08

discussed in standup

@dylankelly dylankelly added this pull request to the merge queue Sep 5, 2023
Merged via the queue into develop with commit c2d6192 Sep 5, 2023
9 checks passed
@waitingallday waitingallday deleted the feature/custom-collection branch October 25, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants