Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1234] include current site ID in search filters #709

Merged
merged 3 commits into from
Jul 14, 2023
Merged

[R20-1234] include current site ID in search filters #709

merged 3 commits into from
Jul 14, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 12, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1234

What I did

  • Include current site ID in search filters, fix filter type
Screenshot 2023-07-12 at 1 43 45 pm

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jul 12, 2023
@codesandbox
Copy link

codesandbox bot commented Jul 12, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented Jul 12, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 2062908
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64b089da6f77fb000851832f

@dylankelly dylankelly added this pull request to the merge queue Jul 14, 2023
Merged via the queue into develop with commit 5df65a0 Jul 14, 2023
@dylankelly dylankelly added this to the 2.1.0 milestone Aug 7, 2023
@lambry lambry deleted the bugfix/R20-1234-content-collection-results branch August 9, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
Needs Code review
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly