Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-538] adding component tests #674

Merged
merged 3 commits into from
Jun 26, 2023
Merged

[R20-538] adding component tests #674

merged 3 commits into from
Jun 26, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 25, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-538

What I did

  • Adding more basic component tests

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@codesandbox
Copy link

codesandbox bot commented Jun 25, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented Jun 25, 2023

Deploy Preview for ripple-docs ready!

Name Link
🔨 Latest commit ec41578
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6498cb893451330008e7f278
😎 Deploy Preview https://deploy-preview-674--ripple-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lambry lambry added this pull request to the merge queue Jun 26, 2023
Merged via the queue into develop with commit a14f1a7 Jun 26, 2023
@lambry lambry deleted the feature/component-tests branch August 9, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants