Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs): 📝 update about information #637

Merged
merged 100 commits into from
Jun 22, 2023

Conversation

dylankelly
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@codesandbox
Copy link

codesandbox bot commented Jun 14, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for ripple-docs ready!

Name Link
🔨 Latest commit a2190d3
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6493916d9b28cb0008ba59e6
😎 Deploy Preview https://deploy-preview-637--ripple-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

layout: page
---

This is how you do that
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waitingallday can I get you to please write this guide? Branch from this branch and write up how to create a new content type in Ripple 2 - leave out the layers stuff, that is covered in #662


Please review the following concepts before proceeding:

- [Content types](../2.key-concepts/4.content-types.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylankelly just a heads up you don't need to add the numbers for URLs. It's probably better to them off too so that changing the order doesn't break the link

Copy link
Contributor Author

@dylankelly dylankelly Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffdowdle its a link to the file not the URL - I have a VS extension to add them in easily, means you don't have to think about the URL and renaming the file can be dealt with via find / replace. But yeah, should probably be consistent lets discuss the best option.

@dylankelly dylankelly marked this pull request as ready for review June 22, 2023 00:08
@dylankelly dylankelly requested a review from waitingallday June 22, 2023 00:09
@jeffdowdle jeffdowdle self-requested a review June 22, 2023 00:11
@dylankelly dylankelly enabled auto-merge June 22, 2023 00:16
@dylankelly dylankelly added this pull request to the merge queue Jun 22, 2023
@dylankelly dylankelly removed this pull request from the merge queue due to a manual request Jun 22, 2023
@dylankelly dylankelly merged commit a920b6c into develop Jun 22, 2023
@dylankelly dylankelly deleted the feature/docs-marketing-copy branch June 22, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants