Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-584] breadcrumb language support #1436

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 2, 2025

Issue: https://digital-vic.atlassian.net/browse/SD-584

What I did

  • Adds breadcrumb language support, we only know the the language of the current page so this just allows for setting the current pages language and direction. We wouldn't want to set direction on the entire breadcrumbs anyway it would break the layout. Also note different fonts can appear slightly differently even with the same font size, line height etc set, this means the alignment of the breadcrumbs text may looks ever so slightly off for certain languages.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.25.0 milestone Feb 2, 2025
@lambry lambry self-assigned this Feb 2, 2025
@dylankelly dylankelly merged commit 82ee7a9 into release/2.25.0 Feb 3, 2025
14 checks passed
@dylankelly dylankelly deleted the feature/breadcrumb-lang branch February 3, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants