Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unneeded key #1434

Merged
merged 1 commit into from
Feb 3, 2025
Merged

chore: remove unneeded key #1434

merged 1 commit into from
Feb 3, 2025

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 2, 2025

What I did

  • Remove unneeded key

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.25.0 milestone Feb 2, 2025
@lambry lambry self-assigned this Feb 2, 2025
@dylankelly dylankelly merged commit dae2de8 into release/2.25.0 Feb 3, 2025
6 checks passed
@dylankelly dylankelly deleted the bugfix/remove-unneeded-key branch February 3, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly