Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-613] add unused apple icons to prevent requests loading up site #1424

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jan 17, 2025

Issue: https://digital-vic.atlassian.net/browse/SD-613

Note: This as a draft for now as the backend needs the app icon field re-added: https://digital-vic.atlassian.net/browse/SD-666

What I did

  • Add unused apple icons to prevent requests loading up site

In sumo you can see requests to a few different apple-touch-icons, these requests occur when safari users use the native share functionality. Despite the fact that we 'register' the correct icon using the link rel tag and webmanifest safari will still make background requests to apple-touch-icon-precomposed.png even though it never uses that file. It seems like the precomposed files haven't even been needed since ios 7. Adding these requested files here prevents these background requests from firing up the site and subsequently making several API requests to Drupal, it also avoids sumo be flooded with irelevant logs about 404'ing files that aren't used.

Testing

I've tested the following devices to make sure the correct icons are still used when clicking share and adding the site to home screen.

  • iOS

  • iOS 18

  • iOS 17

  • iOS 16

  • iOS 15

  • iOS 14

  • Android

  • Android 14

  • Android 13

  • Android 12

  • Android 11

  • Android 10

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Jan 17, 2025
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit bced6ba
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6789d440bf25220008bc2734

@dylankelly dylankelly marked this pull request as ready for review January 20, 2025 22:51
@dylankelly dylankelly self-requested a review January 20, 2025 22:51
@dylankelly dylankelly added this pull request to the merge queue Jan 20, 2025
Merged via the queue into develop with commit 02e40e8 Jan 20, 2025
10 checks passed
@dylankelly dylankelly deleted the bugfix/apple-icon-requests branch January 20, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants