[SD-613] add unused apple icons to prevent requests loading up site #1424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-613
Note: This as a draft for now as the backend needs the app icon field re-added: https://digital-vic.atlassian.net/browse/SD-666
What I did
In sumo you can see requests to a few different apple-touch-icons, these requests occur when safari users use the native share functionality. Despite the fact that we 'register' the correct icon using the link rel tag and webmanifest safari will still make background requests to
apple-touch-icon-precomposed.png
even though it never uses that file. It seems like the precomposed files haven't even been needed since ios 7. Adding these requested files here prevents these background requests from firing up the site and subsequently making several API requests to Drupal, it also avoids sumo be flooded with irelevant logs about 404'ing files that aren't used.Testing
I've tested the following devices to make sure the correct icons are still used when clicking share and adding the site to home screen.
iOS
iOS 18
iOS 17
iOS 16
iOS 15
iOS 14
Android
Android 14
Android 13
Android 12
Android 11
Android 10
Checklist
For all PR's
For new UI components only
emitRplEvent