Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-658] fix html lang #1423

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[SD-658] fix html lang #1423

merged 1 commit into from
Jan 17, 2025

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jan 15, 2025

Issue: https://digital-vic.atlassian.net/browse/SD-658

What I did

  • Fix html lang

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.24.0 milestone Jan 15, 2025
@lambry lambry self-assigned this Jan 15, 2025
@lambry lambry merged commit a2e878a into release/2.24.0 Jan 17, 2025
6 checks passed
@lambry lambry deleted the bugfix/html-lang branch January 17, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle