Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-614] de coupled search submission #1415

Merged
merged 1 commit into from
Dec 30, 2024
Merged

[SD-614] de coupled search submission #1415

merged 1 commit into from
Dec 30, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Dec 27, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-614

What I did

  • Stop the de-coupled search input redirecting to a new page when there is no value set

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.24.0 milestone Dec 27, 2024
@lambry lambry self-assigned this Dec 27, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 27, 2024

ripple-framework    Run #2481

Run Properties:  status check passed Passed #2481  •  git commit 4a87fec57c: fix(@dpc-sdp/ripple-tide-search): stop navigation when there's nothing to naviga...
Project ripple-framework
Branch Review bugfix/de-coupled-search
Run status status check passed Passed #2481
Run duration 10m 27s
Commit git commit 4a87fec57c: fix(@dpc-sdp/ripple-tide-search): stop navigation when there's nothing to naviga...
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 218
View all changes introduced in this branch ↗︎

@lambry lambry merged commit 596674a into release/2.24.0 Dec 30, 2024
6 checks passed
@lambry lambry deleted the bugfix/de-coupled-search branch December 30, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.24.0
Development

Successfully merging this pull request may close these issues.
1 participant
@lambry