Fix data table HTML column labels on mobile #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow data table cell label on mobile.
packages/ripple-ui-core/src/components/data-table/RplDataTableRow.vue
Outdated
Show resolved
Hide resolved
lambry
reviewed
Dec 12, 2024
| @@ -114,8 +114,8 @@ const getCellText = (col?: number | string, value = '') => { | |||
| :is="i === 0 && verticalHeader ? 'th' : 'td'" | |||
| v-for="(column, i) of columns" | |||
| :key="i" | |||
| :data-label="column.label" | |||
There was a problem hiding this comment.
Hey @bgilhome-now, thanks for fixing this.
Can we please add the data-label back in for now, it won't be used for displaying content but there is some other stuff around that utilises it i.e. tests.
Cheers
There was a problem hiding this comment.
Thanks @lambry , done!
waitingallday
approved these changes
Dec 12, 2024
lambry
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug issue #1408
Issue:
What I did
How to test
isLabelHTML: trueand include HTML in thelabel)Checklist
For all PR's
For new UI components only
emitRplEvent