Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-492] update map clusters to match design #1391

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Nov 28, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-492

What I did

  • updated cluster font and sizing to match designs
  • update map snapshot images and fix test vic outline layer

Things of note; currenly clusters overlap but generally the text within the clusters does not, with the updated font and font size we've had to increase the clustering distance slightly so once again the text itself generally won't overlap.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Nov 28, 2024
Copy link

cypress bot commented Nov 28, 2024

ripple-framework    Run #2412

Run Properties:  status check passed Passed #2412  •  git commit 581e2422bd: test(nuxt-app): update map snapshot images, fix vic outline layer
Project ripple-framework
Branch Review feature/map-clusters
Run status status check passed Passed #2412
Run duration 09m 58s
Commit git commit 581e2422bd: test(nuxt-app): update map snapshot images, fix vic outline layer
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@waitingallday waitingallday added this to the 2.22.0 milestone Dec 2, 2024
@lambry lambry merged commit 726e431 into release/2.22.0 Dec 5, 2024
6 of 7 checks passed
@lambry lambry deleted the feature/map-clusters branch December 5, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants