Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-435] disable suggestions by default #1384

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Nov 18, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-435

What I did

  • Disabled search suggestions by default (for search listings and custom collections)
  • Remove "legacy" autocomplete props
  • Make custom collections interoperable with search listings (as far as autocomplete suggestions go)

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Nov 18, 2024
@lambry lambry added this to the 2.21.0 milestone Nov 18, 2024
@lambry lambry merged commit 0d7ebf2 into release/2.21.0 Nov 19, 2024
7 checks passed
@lambry lambry deleted the feature/disable-suggestions branch November 19, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants