Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-339] update filters toggle #1380

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[SD-339] update filters toggle #1380

merged 1 commit into from
Nov 21, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Nov 13, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-339

What I did

  • Update filters label and always show filters toggle

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.21.0 milestone Nov 13, 2024
@lambry lambry self-assigned this Nov 13, 2024
@lambry lambry marked this pull request as ready for review November 19, 2024 02:00
@lambry lambry merged commit 80adc5f into release/2.21.0 Nov 21, 2024
7 checks passed
@lambry lambry deleted the feature/filters-toggle branch November 21, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @jeffdowdle