Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-414] drupal table columns widths #1373

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Nov 12, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-414

What I did

  • Adds support for drupal supplied column widths

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 17bb880
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6733c9642844e100088cefb8

@lambry lambry changed the base branch from develop to release/2.21.0 November 12, 2024 21:33
Copy link

cypress bot commented Nov 12, 2024

ripple-framework    Run #2362

Run Properties:  status check passed Passed #2362  •  git commit 17bb880091: feat(@dpc-sdp/ripple-tide-api): drupal table styles
Project ripple-framework
Branch Review feature/table-col-widths
Run status status check passed Passed #2362
Run duration 10m 05s
Commit git commit 17bb880091: feat(@dpc-sdp/ripple-tide-api): drupal table styles
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎

@lambry lambry marked this pull request as ready for review November 21, 2024 05:55
Copy link
Member

@waitingallday waitingallday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will overwrite any existing style attr, but I think we're clearing those off anyway (or we should if we're not!)

@lambry lambry merged commit 28306ca into release/2.21.0 Nov 21, 2024
13 checks passed
@lambry lambry deleted the feature/table-col-widths branch November 21, 2024 05:59
@lambry
Copy link
Contributor Author

lambry commented Nov 21, 2024

This will overwrite any existing style attr, but I think we're clearing those off anyway (or we should if we're not!)

It will for <col> elements, although you can't add a style tag in the cms to <col> anyway (or anything else), they will always get striped out.

@lambry lambry added this to the 2.21.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants