Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(nuxt-ripple): 🔧 suppress compatibility_date #1363

Merged
merged 1 commit into from
Nov 5, 2024
Merged

perf(nuxt-ripple): 🔧 suppress compatibility_date #1363

merged 1 commit into from
Nov 5, 2024

Conversation

waitingallday
Copy link
Member

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday added this to the 2.20.0 milestone Oct 31, 2024
@waitingallday waitingallday self-assigned this Oct 31, 2024
@dylankelly
Copy link
Contributor

🎃 👻

@cypress Cypress
Copy link

cypress bot commented Oct 31, 2024

ripple-framework    Run #2337

Run Properties:  status check passed Passed #2337  •  git commit c244a640b4: perf(nuxt-ripple): :wrench: suppress compatibility_date
Project ripple-framework
Branch Review task/compatibility-date
Run status status check passed Passed #2337
Run duration 09m 08s
Commit git commit c244a640b4: perf(nuxt-ripple): :wrench: suppress compatibility_date
Committer Jason Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 209
View all changes introduced in this branch ↗︎

@waitingallday waitingallday merged commit 5dd3625 into release/2.20.0 Nov 5, 2024
6 checks passed
@waitingallday waitingallday deleted the task/compatibility-date branch November 5, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@lambry lambry Awaiting requested review from lambry

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@waitingallday @dylankelly