Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@dpc-sdp/ripple-tide-search): fix issue with search listing dropdwn reactivity #1358

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(@dpc-sdp/ripple-tide-search): fix issue with search listing dropdwn reactivity #1358

merged 1 commit into from
Oct 28, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@netlify Netlify
Copy link

netlify bot commented Oct 24, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit b447a53
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6719c9f8bec5b50008d6c50e

@cypress Cypress
Copy link

cypress bot commented Oct 24, 2024 •
edited
Loading

ripple-framework    Run #2320

Run Properties:  status check passed Passed #2320  •  git commit b447a535da: fix(@dpc-sdp/ripple-tide-search): fix issue with search listing dropdown reactiv...
Project ripple-framework
Branch Review 2.17.2.alpha.1
Run status status check passed Passed #2320
Run duration 08m 56s
Commit git commit b447a535da: fix(@dpc-sdp/ripple-tide-search): fix issue with search listing dropdown reactiv...
Committer Jeffrey Dowdle
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 201
View all changes introduced in this branch ↗︎

@jeffdowdle jeffdowdle changed the base branch from develop to release/2.17.2 October 24, 2024 04:34
@jeffdowdle jeffdowdle closed this Oct 24, 2024
@jeffdowdle jeffdowdle reopened this Oct 24, 2024
@dylankelly dylankelly changed the base branch from release/2.17.2 to release/2.19.0 October 28, 2024 23:11
@dylankelly dylankelly merged commit 9a7a749 into release/2.19.0 Oct 28, 2024
21 of 22 checks passed
@dylankelly dylankelly deleted the bugfix/search-listing-agg-fix branch October 28, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @lambry @dylankelly