Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-329] per site section quick exit #1357

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Oct 23, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-329

What I did

  • Allow quick exit to be overridden per site section

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.19.0 milestone Oct 23, 2024
@lambry lambry self-assigned this Oct 23, 2024
Copy link

cypress bot commented Oct 23, 2024

ripple-framework    Run #2316

Run Properties:  status check passed Passed #2316  •  git commit 7c0ce6f08d: feat(@dpc-sdp/nuxt-ripple): site specific quick exit
Project ripple-framework
Branch Review feature/per-site-quick-exit
Run status status check passed Passed #2316
Run duration 10m 45s
Commit git commit 7c0ce6f08d: feat(@dpc-sdp/nuxt-ripple): site specific quick exit
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 209
View all changes introduced in this branch ↗︎

@dylankelly dylankelly merged commit ee0d3c8 into release/2.19.0 Oct 23, 2024
6 checks passed
@dylankelly dylankelly deleted the feature/per-site-quick-exit branch October 23, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants