Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧 update publish config to handle draft releases #1353

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

dylankelly
Copy link
Contributor

@dylankelly dylankelly commented Oct 16, 2024

Issue:

What I did

modifies publish on release workflow to do the following

  • If the release is not marked pre-prod
    • Runs package version update and changelog creation scripts using the name of the release as the version number
    • Commits the result
    • Publishes to GPR
  • If the release is marked as pre-prod
    • publishes to alpha dist tag using git sha version identifier
    • Does not commit

How to test

  • Not sure how to test this prior to merging - I think we may need to YOLO it

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 7f771d8
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/670f3aabc854a20009a5f828

@dylankelly dylankelly self-assigned this Oct 16, 2024
@dylankelly dylankelly modified the milestone: 2.19.0 Oct 16, 2024
@dylankelly dylankelly added this pull request to the merge queue Oct 16, 2024
Merged via the queue into develop with commit 83041b6 Oct 16, 2024
7 checks passed
@dylankelly dylankelly deleted the feature/release-process branch October 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants