Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-366] breadcrumb issues #1350

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[SD-366] breadcrumb issues #1350

merged 2 commits into from
Oct 14, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Oct 14, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-366

What I did

  • Make font sizing consistent
  • Check if links should collapse before collapsing
  • Add component tests and feature flag test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.18.0 milestone Oct 14, 2024
@lambry lambry self-assigned this Oct 14, 2024
@cypress Cypress
Copy link

cypress bot commented Oct 14, 2024 •
edited
Loading

ripple-framework    Run #2293

Run Properties:  status check passed Passed #2293  •  git commit 9263e25e95: feat(@dpc-sdp/ripple-ui-maps): fix for storybook test
Project ripple-framework
Run status status check passed Passed #2293
Run duration 10m 03s
Commit git commit 9263e25e95: feat(@dpc-sdp/ripple-ui-maps): fix for storybook test
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 202

@dylankelly dylankelly merged commit 7bac6c3 into release/2.18.0 Oct 14, 2024
6 checks passed
@dylankelly dylankelly deleted the bugfix/breadcrumb-ellipsis branch October 14, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lambry @dylankelly