Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-333] Change map popover styling to match designs #1347

Merged
merged 2 commits into from
Oct 10, 2024
Merged

[SD-333] Change map popover styling to match designs #1347

merged 2 commits into from
Oct 10, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-333

What I did

Old:

Screenshot 2024-10-09 at 12 49 46 PM

New:

Screenshot 2024-10-09 at 1 06 36 PM

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 2c303a9
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6705e5aa290228000867ee0d

@jeffdowdle jeffdowdle changed the base branch from develop to release/2.18.0 October 9, 2024 02:09
@jeffdowdle jeffdowdle changed the title Bugfix/sd 333 popup styling [SD-333] Change map popover styling to match designs Oct 9, 2024
@cypress Cypress
Copy link

cypress bot commented Oct 9, 2024

ripple-framework    Run #2287

Run Properties:  status check passed Passed #2287  •  git commit 4680089e2a: style(@dpc-sdp/ripple-ui-maps): fixed incorrect comment
Project ripple-framework
Run status status check passed Passed #2287
Run duration 09m 05s
Commit git commit 4680089e2a: style(@dpc-sdp/ripple-ui-maps): fixed incorrect comment
Committer Jeffrey Dowdle
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 201

@jeffdowdle jeffdowdle added this to the 2.18.0 milestone Oct 10, 2024
@jeffdowdle jeffdowdle merged commit f17fb75 into release/2.18.0 Oct 10, 2024
6 checks passed
@jeffdowdle jeffdowdle deleted the bugfix/SD-333-popup-styling branch October 10, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdowdle @lambry