Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-257] - Added 'form start' analytics event #1330

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-257

What I did

  • Added 'form start' analytics event

How to test

  • Added Cypress test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle added this to the 2.17.0 milestone Sep 18, 2024
Copy link

cypress bot commented Sep 18, 2024

ripple-framework    Run #2238

Run Properties:  status check passed Passed #2238  •  git commit 2cc23d2818: refactor(@dpc-sdp/ripple-ui-forms): use input instead of change event for form_s...
Project ripple-framework
Branch Review feature/SD-257-form-start-event
Run status status check passed Passed #2238
Run duration 08m 46s
Commit git commit 2cc23d2818: refactor(@dpc-sdp/ripple-ui-forms): use input instead of change event for form_s...
Committer Jeffrey Dowdle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 197
View all changes introduced in this branch ↗︎

@lambry
Copy link
Contributor

lambry commented Sep 18, 2024

Hey @jeffdowdle,

Are you able to add the event to defineEmits here as well:

Cheers

… for form_start event

now fires immediately instead of waiting for blur of the field
@dylankelly dylankelly merged commit e2bf386 into release/2.17.0 Sep 24, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the feature/SD-257-form-start-event branch September 24, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants