Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-198] Reusable paragraphs #1315

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-198

What I did

  • Cherry picked Bryce's POC over from his fork to publish an alpha for integration testing
  • Added a whitelist in types to give some control over which paragraphs have the reusable include added (the API response is fairly resilient, but just wanted to avoid running up too many includes in cases where it clearly isn't needed/used)

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday added this to the 2.16.0 milestone Sep 5, 2024
@waitingallday waitingallday self-assigned this Sep 5, 2024
@waitingallday waitingallday mentioned this pull request Sep 5, 2024
6 tasks
Copy link

cypress bot commented Sep 5, 2024

ripple-framework    Run #2188

Run Properties:  status check passed Passed #2188  •  git commit 61a5655d3b: refactor(@dpc-sdp/ripple-tide-landing-page): :recycle: add whitelist for reusabl...
Project ripple-framework
Branch Review feat/sd-198-reusable-paragraphs
Run status status check passed Passed #2188
Run duration 08m 37s
Commit git commit 61a5655d3b: refactor(@dpc-sdp/ripple-tide-landing-page): :recycle: add whitelist for reusabl...
Committer Jason Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 193
View all changes introduced in this branch ↗︎

@dylankelly dylankelly merged commit d6a8ea7 into release/2.16.0 Sep 6, 2024
6 checks passed
@dylankelly dylankelly deleted the feat/sd-198-reusable-paragraphs branch September 6, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants