Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDPAP-9439] tweak ar line height #1241

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[SDPAP-9439] tweak ar line height #1241

merged 1 commit into from
Jul 1, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 30, 2024

Issue: https://digital-vic.atlassian.net/browse/SDPAP-9439

What I did

  • Tweak ar line height

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 30, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 30, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit c95d209
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6681edd08beb790008fd45b2

@cypress Cypress
Copy link

cypress bot commented Jun 30, 2024

Passing run #1997 ↗︎

0 174 0 0 Flakiness 0

Details:

feat(@dpc-sdp/nuxt-ripple): tweak ar line height
Project: ripple-framework Commit: c95d2093d2
Status: Passed Duration: 07:33 💡
Started: Jun 30, 2024 11:37 PM Ended: Jun 30, 2024 11:45 PM

Review all test suite changes for PR #1241 ↗︎

@dylankelly dylankelly enabled auto-merge July 1, 2024 00:01
@dylankelly dylankelly added this pull request to the merge queue Jul 1, 2024
Merged via the queue into develop with commit b91226a Jul 1, 2024
8 checks passed
@dylankelly dylankelly deleted the bugfix/SDPAP-9439-ar-font branch July 1, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly