[R20-1969] add skeletons to site search #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ripple-docs canceled.
|
waitingallday
approved these changes
Jun 21, 2024
Passing run #1975 ↗︎
Details:
Review all test suite changes for PR #1233 ↗︎ |
|||||||||||||||
jeffdowdle
approved these changes
Jun 23, 2024
dylankelly
requested changes
Jun 24, 2024
packages/ripple-tide-search/components/global/TideCustomCollection.vue
Outdated
Show resolved
Hide resolved
…dd const for scroll offset
lambry
commented
Jun 24, 2024
…dd const for scroll offset
dylankelly
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/R20-1969
What I did
site-search.mov
Notes
One change in this PR is to swap the element type (in the search result layout components) when loading has completed, this was best way to ensure the results correctly replace skeleton screens in cypress. Without it cypress will show the result content merged into the skeleton components (as seen below).
For all PR's
For new components only