Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-2046] hide refine search when filters are already open #1230

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[R20-2046] hide refine search when filters are already open #1230

merged 1 commit into from
Jun 21, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 20, 2024 •
edited
Loading

Jira: https://digital-vic.atlassian.net/browse/R20-2046

What I did

  • Hide refine search when filters are already open

Screenshot 2024-06-20 at 11 51 49 AM

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 20, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 20, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 7f0f5eb
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66738b7abc972b000826caed

@cypress Cypress
Copy link

cypress bot commented Jun 20, 2024

Passing run #1937 ↗︎

0 170 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-tide-search): hide refine search when filters are already o...
Project: ripple-framework Commit: 7f0f5eb1e4
Status: Passed Duration: 08:02 💡
Started: Jun 20, 2024 1:51 AM Ended: Jun 20, 2024 2:00 AM

Review all test suite changes for PR #1230 ↗︎

@lambry lambry changed the title feat(@dpc-sdp/ripple-tide-search): hide refine search when filters are already open [R20-2046] hide refine search when filters are already open Jun 20, 2024
@dylankelly dylankelly added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit 72deac2 Jun 21, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/hide-refine-search branch June 21, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly