Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1451] - Set a max length on site search bar to match search ui max length #1208

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented Jun 4, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1451

What I did

  • Search UI errors if the query is longer than 128 characters, so I set a max length on the input so the user won't get this error when copy pasting a lot of text

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Jun 4, 2024
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 5ac8a8e
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/665e9590fcfa16000800df0c

Copy link

cypress bot commented Jun 4, 2024

Passing run #1854 ↗︎

0 161 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): set a max length on site search bar to match s...
Project: ripple-framework Commit: 5ac8a8ee98
Status: Passed Duration: 07:34 💡
Started: Jun 4, 2024 4:19 AM Ended: Jun 4, 2024 4:26 AM

Review all test suite changes for PR #1208 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Jun 5, 2024
Merged via the queue into develop with commit 8cbd3ed Jun 5, 2024
16 checks passed
@dylankelly dylankelly deleted the bugfix/R20-1451-search-ui-max-length branch June 5, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants