Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(@dpc-sdp/ripple-ui-core): fix primary nav alignment #1204

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 3, 2024

Issue: #1112

What I did

  • Fixes alignment on primary nav
  • Also fixes 'line height' for items that wrap

Screen Recording 2024-06-04 at 9 29 19 AM

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 3, 2024
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 1f0043d
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/665e561af865930008d83b30

Copy link

cypress bot commented Jun 3, 2024

Passing run #1845 ↗︎

0 160 0 0 Flakiness 0

Details:

style(@dpc-sdp/ripple-ui-core): fix primary nav alignment
Project: ripple-framework Commit: 1f0043d3c2
Status: Passed Duration: 06:44 💡
Started: Jun 3, 2024 11:46 PM Ended: Jun 3, 2024 11:53 PM

Review all test suite changes for PR #1204 ↗︎

@dylankelly
Copy link
Contributor

closes #1112

@dylankelly dylankelly closed this Jun 4, 2024
@dylankelly dylankelly reopened this Jun 4, 2024
@dylankelly dylankelly added this pull request to the merge queue Jun 4, 2024
Merged via the queue into develop with commit b42a96e Jun 4, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the bugfix/primary-nav-alignment branch June 4, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants