Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(@dpc-sdp/nuxt-ripple-cli): update new project template #1203

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore(@dpc-sdp/nuxt-ripple-cli): update new project template #1203

merged 1 commit into from
Jun 4, 2024

Conversation

dylankelly
Copy link
Contributor

Issue:

What I did

  • Update CLI new site template

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 0c5763b
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/665e546ab26e450008523a42

@cypress Cypress
Copy link

cypress bot commented Jun 3, 2024

Passing run #1844 ↗︎

0 160 0 0 Flakiness 0

Details:

chore(@dpc-sdp/nuxt-ripple-cli): update new project template
Project: ripple-framework Commit: 0c5763b2c1
Status: Passed Duration: 06:50 💡
Started: Jun 3, 2024 11:42 PM Ended: Jun 3, 2024 11:49 PM

Review all test suite changes for PR #1203 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Jun 4, 2024
Merged via the queue into develop with commit 33ac140 Jun 4, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/update-new-site-template branch June 4, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dylankelly @lambry @waitingallday @jeffdowdle