Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-464] radio and checkbox touch targets #1197

Merged
merged 2 commits into from
May 31, 2024
Merged

[R20-464] radio and checkbox touch targets #1197

merged 2 commits into from
May 31, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented May 30, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-464

What I did

  • Make checkboxes and radio buttons meet touch target size as per design doc

Screenshots (before and after)

Screenshot 2024-05-31 at 9 24 44 AM Screenshot 2024-05-31 at 9 23 35 AM

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this May 30, 2024
@netlify Netlify
Copy link

netlify bot commented May 30, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 07a3dd1
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66590ec92054b3000857bff0

@cypress Cypress
Copy link

cypress bot commented May 30, 2024 •
edited
Loading

Passing run #1821 ↗︎

0 155 0 0 Flakiness 0

Details:

Merge branch 'develop' into feature/form-touch-targets
Project: ripple-framework Commit: 07a3dd1252
Status: Passed Duration: 08:24 💡
Started: May 30, 2024 11:44 PM Ended: May 30, 2024 11:53 PM

Review all test suite changes for PR #1197 ↗︎

@lambry lambry added this pull request to the merge queue May 31, 2024
Merged via the queue into develop with commit 0041939 May 31, 2024
15 of 16 checks passed
@lambry lambry deleted the feature/form-touch-targets branch May 31, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle