Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-2030] fix callout margin #1196

Merged
merged 1 commit into from
May 30, 2024
Merged

[R20-2030] fix callout margin #1196

merged 1 commit into from
May 30, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented May 30, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-2030

What I did

  • Just fixes the margin at the top of CMS call outs

Before and after

Screenshot 2024-05-30 at 5 31 31 PM

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this May 30, 2024
@netlify Netlify
Copy link

netlify bot commented May 30, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit a585dda
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66590d56ff90370008026509

@dylankelly dylankelly added this pull request to the merge queue May 30, 2024
Merged via the queue into develop with commit e8b0266 May 30, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the bugfix/R20-2030-callout-gap branch May 30, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle