Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-2028, R20-2019] Geolocate button messages and labels #1194

Merged
merged 3 commits into from
May 31, 2024
Merged

[R20-2028, R20-2019] Geolocate button messages and labels #1194

merged 3 commits into from
May 31, 2024

Conversation

jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented May 29, 2024 •
edited
Loading

Issues:

Screenshot 2024-05-30 at 11 35 56 am
Screenshot 2024-05-30 at 11 35 49 am

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this May 29, 2024
@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 87ce103
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6657d7c13650b10008a67c41

@cypress Cypress
Copy link

cypress bot commented May 29, 2024 •
edited
Loading

Passing run #1817 ↗︎

0 155 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-maps): updated geolocate error message and styling based...
Project: ripple-framework Commit: 87ce103802
Status: Passed Duration: 06:49 💡
Started: May 30, 2024 1:37 AM Ended: May 30, 2024 1:44 AM

Review all test suite changes for PR #1194 ↗︎

@jeffdowdle jeffdowdle changed the title [R20-2028] Made geolocate button label configurable [R20-2028, R20-2019] Made geolocate button label configurable May 29, 2024
@jeffdowdle jeffdowdle changed the title [R20-2028, R20-2019] Made geolocate button label configurable [R20-2028, R20-2019] Geolocate button messages and labels May 29, 2024
@dylankelly dylankelly enabled auto-merge May 30, 2024 23:48
@dylankelly dylankelly added this pull request to the merge queue May 31, 2024
Merged via the queue into develop with commit 78963e5 May 31, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/R20-2028-geolocate-label branch May 31, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @lambry @dylankelly