Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-713] fix spacing, add refine tally #1185

Merged
merged 1 commit into from
May 24, 2024
Merged

[R20-713] fix spacing, add refine tally #1185

merged 1 commit into from
May 24, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented May 23, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-713

What I did

  • Fix filter spacing
  • Add refine tally
  • Add some search tests

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this May 23, 2024
@netlify Netlify
Copy link

netlify bot commented May 23, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 3794829
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/664fd2d0af4f570008b91ed2

@dylankelly dylankelly added this pull request to the merge queue May 24, 2024
Merged via the queue into develop with commit 6183042 May 24, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/R20-713-search-feedback branch May 24, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly