Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@dpc-sdp/ripple-tide-search): fix issue with search dropdown option reactivity #1183

Merged
merged 1 commit into from
May 23, 2024
Merged

feat(@dpc-sdp/ripple-tide-search): fix issue with search dropdown option reactivity #1183

merged 1 commit into from
May 23, 2024

Conversation

jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented May 23, 2024 •
edited
Loading

Issue: #1104

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this May 23, 2024
@netlify Netlify
Copy link

netlify bot commented May 23, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 726494f
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/664ecf0682ef910008d4234a

@cypress Cypress
Copy link

cypress bot commented May 23, 2024

Passing run #1773 ↗︎

0 150 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-tide-search): fix issue with search dropdown option reactiv...
Project: ripple-framework Commit: 726494f039
Status: Passed Duration: 06:41 💡
Started: May 23, 2024 5:09 AM Ended: May 23, 2024 5:15 AM

Review all test suite changes for PR #1183 ↗︎

@dylankelly dylankelly added this pull request to the merge queue May 23, 2024
Merged via the queue into develop with commit bb26481 May 23, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/custom-result-mapping branch May 23, 2024 05:31
@lambry lambry mentioned this pull request Nov 8, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffdowdle @lambry @waitingallday @dylankelly