Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1981] fix search listing dropdowns #1153

Merged
merged 1 commit into from
May 8, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented May 7, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1981

What I did

  • Fix the search listing dropdowns that use elasticsearch, ref: https://www.v2.www.vic.gov.au/family-violence-recommendations
  • Also updated the min_doc_count param so 'empty' results are only returned when using dynamicAggregations, this essentially reverts the default behavior back to how it was, i.e elastic aggregation only return items with docs

Issue

search-listing-dropdowns

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 9d0b0bd
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6639d4dba100830008d0c29f

@dylankelly dylankelly added this pull request to the merge queue May 8, 2024
Merged via the queue into develop with commit d84d90f May 8, 2024
8 checks passed
@dylankelly dylankelly deleted the bugfix/R20-1981-listing-aggregations branch May 8, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants