Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1906] Added missing underline to pagination next/prev buttons #1117

Merged
merged 2 commits into from
Apr 18, 2024
Merged

[R20-1906] Added missing underline to pagination next/prev buttons #1117

merged 2 commits into from
Apr 18, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/R20-1906

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Apr 18, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit caa24bb
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/662079381173490008faaae0

@cypress Cypress
Copy link

cypress bot commented Apr 18, 2024

Passing run #1561 ↗︎

0 140 0 0 Flakiness 0

Details:

Merge branch 'develop' into bugfix/R20-1906-pagination-underline
Project: ripple-framework Commit: caa24bbff9
Status: Passed Duration: 07:05 💡
Started: Apr 18, 2024 1:39 AM Ended: Apr 18, 2024 1:46 AM

Review all test suite changes for PR #1117 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Apr 18, 2024
Merged via the queue into develop with commit 12746ca Apr 18, 2024
16 checks passed
@dylankelly dylankelly deleted the bugfix/R20-1906-pagination-underline branch April 18, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffdowdle @lambry @waitingallday @dylankelly