Merge pull request #874 from dpc-sdp/fix/r20-1553-pagelink-text

[R20-1553] Change page link props at mapping
dpc-sdp · Oct 3, 2023 · e8b484c · e8b484c
2 parents 9db150a + 5d7bbc3
commit e8b484c
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 10 deletions.
diff --git a/examples/nuxt-app/test/features/publication-page/publication-page.feature b/examples/nuxt-app/test/features/publication-page/publication-page.feature
@@ -11,3 +11,5 @@ Feature: Publication page page
   Example: On load
     When I visit the page "/demo-publication/demo-publication-chapter-1"
     Then the title should be "Demo Publication - Chapter 1"
+    And there should be a page link with a title of "Previous" and description text of "Demo Publication"
+    And there should be a page link with a title of "Next" and description text of "Demo Publication - Chapter 1 - Page 1"
diff --git a/examples/nuxt-app/test/fixtures/publication-page/sample-publication-page.json b/examples/nuxt-app/test/fixtures/publication-page/sample-publication-page.json
@@ -190,14 +190,14 @@
     ],
     "pagination": {
       "prev": {
-        "text": "Demo Publication",
+        "text": "Previous",
         "url": "/demo-publication",
-        "description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam tincidunt sit amet ligula sit amet lacinia. In a leo nec tortor aliquet faucibus."
+        "description": "Demo Publication"
       },
       "next": {
-        "text": "Demo Publication - Chapter 1 - Page 1",
+        "text": "Next",
         "url": "/demo-publication/demo-publication-chapter-1/demo-publication-chapter-1-page-1",
-        "description": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam tincidunt sit amet ligula sit amet lacinia. In a leo nec tortor aliquet faucibus."
+        "description": "Demo Publication - Chapter 1 - Page 1"
       }
     }
   },

diff --git a/packages/ripple-test-utils/step_definitions/content-types/publication.ts b/packages/ripple-test-utils/step_definitions/content-types/publication.ts
@@ -0,0 +1,9 @@
+import { Then } from '@badeball/cypress-cucumber-preprocessor'
+
+Then(
+  'there should be a page link with a title of {string} and description text of {string}',
+  (title: string, desc: string) => {
+    cy.get('.rpl-page-links__link-label').contains(title).should('exist')
+    cy.get('.rpl-page-links__link-text').contains(desc).should('exist')
+  }
+)
diff --git a/packages/ripple-tide-publication/mapping/publication-page.ts b/packages/ripple-tide-publication/mapping/publication-page.ts
@@ -61,16 +61,14 @@ const tidePublicationPageModule: IRplTideModuleMapping = {
         })),
       pagination: {
         prev: {
-          label: 'publication_navigation_prev.meta.title',
+          label: () => 'Previous',
           url: 'publication_navigation_prev.meta.url',
-          description:
-            'publication_navigation_prev.meta.field_landing_page_summary'
+          description: 'publication_navigation_prev.meta.title'
         },
         next: {
-          label: 'publication_navigation_next.meta.title',
+          label: () => 'Next',
           url: 'publication_navigation_next.meta.url',
-          description:
-            'publication_navigation_next.meta.field_landing_page_summary'
+          description: 'publication_navigation_next.meta.title'
         }
       }
     },