fix(@dpc-sdp/ripple-tide-search): added missing aria-expanded to sear…

…ch filter toggle
dpc-sdp · Sep 19, 2023 · d6601e8 · d6601e8
1 parent 7c2dc41
commit d6601e8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/packages/ripple-tide-search/components/TideSearchListingPage.vue b/packages/ripple-tide-search/components/TideSearchListingPage.vue
@@ -330,11 +330,13 @@ watch(
             v-if="userFilters && userFilters.length > 0"
             class="tide-search-refine-btn"
             :expanded="filtersExpanded"
+            aria-controls="tide-search-listing-filters"
             @click="handleToggleFilters"
             >{{ toggleFiltersLabel }}</RplSearchBarRefine
           >
           <RplExpandable
             v-if="userFilters && userFilters.length > 0"
+            id="tide-search-listing-filters"
             :expanded="filtersExpanded"
             class="rpl-u-margin-t-4"
           >

diff --git a/packages/ripple-tide-search/components/TideSearchPage.vue b/packages/ripple-tide-search/components/TideSearchPage.vue
@@ -223,10 +223,14 @@ watch(
           <RplSearchBarRefine
             class="tide-search-refine-btn"
             :expanded="filtersExpanded"
+            aria-controls="tide-search-page-filters"
             @click="toggleFilters"
             >{{ toggleFiltersLabel }}</RplSearchBarRefine
           >
-          <RplExpandable :expanded="filtersExpanded">
+          <RplExpandable
+            id="tide-search-page-filters"
+            :expanded="filtersExpanded"
+          >
             <RplForm
               v-if="staticFacetOptions !== null"
               id="tide-search-filter-form"

diff --git a/packages/ripple-ui-core/src/components/search-bar/RplSearchBarRefine.vue b/packages/ripple-ui-core/src/components/search-bar/RplSearchBarRefine.vue
@@ -16,6 +16,7 @@ withDefaults(defineProps<Props>(), {
 
 <template>
   <button
+    :aria-expanded="expanded"
     :class="{
       'rpl-search-bar-refine': true,
       'rpl-search-bar-refine--expanded': expanded,