Skip to content

Commit

Permalink
Merge pull request #771 from dpc-sdp/chore/vm2-removal
Browse files Browse the repository at this point in the history
chore: remove all usage of deprecated vm2 package
  • Loading branch information
jeffdowdle authored Aug 15, 2023
2 parents 13539f8 + 455dc6c commit 3a58251
Show file tree
Hide file tree
Showing 5 changed files with 67 additions and 857 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/nuxt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ jobs:

- run: npm install ./packages/nuxt-ripple-cli --global
# Run lighthouse test against nuxt-app example
- name: Run lighthouse baseline test on nuxt-app
run: pnpm -F nuxt-app lighthouse:ci
# TODO Turn lighthouse back on after unlighthouse is patched
# - name: Run lighthouse baseline test on nuxt-app
# run: pnpm -F nuxt-app lighthouse:ci

# run Cypress tests in example nuxt-app, record to Cypress cloud
Integration:
Expand Down
5 changes: 1 addition & 4 deletions examples/nuxt-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
"cy:open": "cypress open --e2e --browser electron",
"cy:run": "cypress run --record",
"test:ci": "NUXT_PUBLIC_API_URL=http://localhost:3001 API_PORT=3001 start-test start tcp:3000 'cy:run'",
"test:integration": "start-test 'NUXT_PUBLIC_API_URL=http://localhost:3001 API_PORT=3001 pnpm dev' 'http-get://localhost:3000/api/tide/site?id=8888' 'cy:open'",
"lighthouse": "unlighthouse-ci --site http://localhost:3000",
"lighthouse:ci": "start-test start:mock 3000 lighthouse"
"test:integration": "start-test 'NUXT_PUBLIC_API_URL=http://localhost:3001 API_PORT=3001 pnpm dev' 'http-get://localhost:3000/api/tide/site?id=8888' 'cy:open'"
},
"dependencies": {
"@dpc-sdp/nuxt-ripple": "workspace:*",
Expand All @@ -38,7 +36,6 @@
"@dpc-sdp/ripple-test-utils": "workspace:*",
"@dpc-sdp/ripple-tide-api": "workspace:*",
"@nuxt/devtools": "^0.6.7",
"@unlighthouse/cli": "^0.9.0",
"cypress": "12.8.1",
"node-fetch-native": "^1.0.2",
"nuxt": "3.6.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/nuxt-ripple-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"copyfiles": "^2.4.1",
"enquirer": "^2.3.6",
"hygen": "^6.2.11",
"mockttp": "^3.7.5",
"mockttp": "^3.9.1",
"npm-check-updates": "^16.10.16",
"object-to-argv": "^2.0.0",
"rimraf": "^4.4.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/ripple-test-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@bahmutov/cypress-esbuild-preprocessor": "^2.2.0",
"@testing-library/cypress": "^9.0.0",
"cypress": "^12.8.1",
"mockttp": "^3.7.5",
"mockttp": "^3.9.1",
"start-server-and-test": "^2.0.0"
}
}
Loading

0 comments on commit 3a58251

Please sign in to comment.