Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin imports using product-level CocoaPods #812

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

gillycheesesteak
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

The switch to product pods (#811) broke builds because of the missing Firebase.h file. This adds FirebaseWrapper.h which replicates the behavior of that file from the top-level Firebase pod.

It also removes some code that attempts to modify the plugin.xml file before the first pod install to use the pre-built Firestore, which was not functioning because Cordova reads the plugin.xml file into memory before firing that hook.

NOTE: The precompiled Firestore flag still does not work because of the issue described here: invertase/firestore-ios-sdk-frameworks#62

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

@sestienne
Copy link

Thanks a lot your solution works very.
I do not force to use precompile firestore pod file by changing plugin.xml as we build on a Mac M1 (see error : ld: symbol(s) not found for architecture arm64, open issue : invertase/firestore-ios-sdk-frameworks#71)

@mehmetkaynak
Copy link

any updates?

@ensemblebd
Copy link

Really appreciate your work to resolve this.
Just wish I had seen this sooner, wasted a solid 6+ hours, searching for why "Firebase.h" didn't exist, and ending up in rabbit-hole after rabbit-hole.

Hoping to see it merged into main soon.
Tested functional for me as well. (note: I'm also on an M1 chip, & project is meteorjs cordova)

@dpa99c dpa99c merged commit d699109 into dpa99c:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants