Fix plugin imports using product-level CocoaPods #812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check your PR fulfills the following requirements:
Bugfixes:
New features/enhancements:
What is the purpose of this PR?
The switch to product pods (#811) broke builds because of the missing
Firebase.h
file. This addsFirebaseWrapper.h
which replicates the behavior of that file from the top-levelFirebase
pod.It also removes some code that attempts to modify the
plugin.xml
file before the firstpod install
to use the pre-built Firestore, which was not functioning because Cordova reads theplugin.xml
file into memory before firing that hook.NOTE: The precompiled Firestore flag still does not work because of the issue described here: invertase/firestore-ios-sdk-frameworks#62
Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
What testing has been done on existing functionality?
Other information