Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get default host instead of 127.0.0.1 #731

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Feb 20, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq temporarily deployed to tablestore-live February 20, 2023 08:22 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #731 (5f889cc) into master (cbd423b) will increase coverage by 0.12%.
The diff coverage is 66.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   53.59%   53.72%   +0.12%     
==========================================
  Files         196      196              
  Lines       10831    10837       +6     
==========================================
+ Hits         5805     5822      +17     
+ Misses       4579     4569      -10     
+ Partials      447      446       -1     
Impacted Files Coverage Δ
pkg/server/init.go 64.28% <66.66%> (+1.78%) ⬆️
pkg/registry/etcdv3/registry.go 72.26% <0.00%> (+1.02%) ⬆️
pkg/executor/xxl/task.go 69.64% <0.00%> (+2.67%) ⬆️
pkg/util/xnet/ip.go 15.21% <0.00%> (+15.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq merged commit 07c65c1 into master Feb 20, 2023
@sysulq sysulq deleted the feat/defaultHost branch March 31, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants