Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate tools dependency from jupiter #719

Merged
merged 4 commits into from
Feb 14, 2023
Merged

feat: separate tools dependency from jupiter #719

merged 4 commits into from
Feb 14, 2023

Conversation

sysulq
Copy link
Member

@sysulq sysulq commented Feb 14, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sysulq sysulq temporarily deployed to tablestore-live February 14, 2023 03:05 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #719 (335ef7b) into master (07e51e6) will decrease coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
- Coverage   53.50%   53.43%   -0.07%     
==========================================
  Files         191      191              
  Lines       10545    10545              
==========================================
- Hits         5642     5635       -7     
- Misses       4477     4484       +7     
  Partials      426      426              
Impacted Files Coverage Δ
pkg/store/gorm/logger.go 37.50% <0.00%> (-14.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sysulq sysulq temporarily deployed to tablestore-live February 14, 2023 03:10 — with GitHub Actions Inactive
@sysulq sysulq changed the title feat: separate tools dependency from layout feat: separate tools dependency from jupiter Feb 14, 2023
@sysulq sysulq temporarily deployed to tablestore-live February 14, 2023 03:16 — with GitHub Actions Inactive
@sysulq sysulq merged commit ac31c06 into master Feb 14, 2023
@sysulq sysulq deleted the feat/tools branch February 17, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants